Find generator variables without fake early declarations
ClosedPublic
Actions

Authored by flherne on Aug 28 2017, 9:49 PM.

Details

Reviewers

Commits

R53:b553d75e4df8: Find generator variables without fake early declarations

Summary

This causes the real point of declaration to be bolded/highlighted. It also means all declarations have the same range as their NameAst node, which should allow simplification of some other code (not in this patch).

Test Plan

Doesn't break the tests. TODO: add some more, including some already-broken cases I discovered, and do some duchainify runs.

Diff Detail

Repository

R53 KDevelop: Python Support

Lint

Lint Skipped

Unit

Unit Tests Skipped

flherne created this revision.Aug 28 2017, 9:49 PM

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptAug 28 2017, 9:49 PM

Good solution I think, better than the hack from before (because it actually does the right thing, in a way). Feel free to put it into 5.2, we still have a few weeks to catch issues it causes. Thanks!

This revision is now accepted and ready to land.Aug 28 2017, 9:52 PM

Closed by commit R53:b553d75e4df8: Find generator variables without fake early declarations (authored by flherne). · Explain WhyAug 31 2017, 1:23 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			codecompletion/context.cpp (2 lines)
M			duchain/declarationbuilder.cpp (20 lines)
M			duchain/expressionvisitor.cpp (4 lines)
M			duchain/helpers.h (5 lines)
M			duchain/helpers.cpp (30 lines)
M			duchain/usebuilder.cpp (3 lines)