Step doesn't use any cln code directly, only via libqalculate. In version 2.0, libqalculate dropped cln in favor of gmp, so the cln dependency becomes unnecessary.
Details
Details
- Reviewers
ltoscano - Group Reviewers
KDE Edu - Commits
- R341:d5412ebc25ab: Don't search for and link to libcln when using libqalculate>=2.0
Builds and works with libqalculate 1.0 (which uses cln) and 2.0 (which doesn't)
Diff Detail
Diff Detail
- Repository
- R341 Step
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Shouldn't also the following line be changed (step/CMakeLists.txt)?
set(qalculate_LIBS ${QALCULATE_LIBRARIES} ${CLN_LIBRARIES})
I understand that CLN_LIBRARIES would be empty, so maybe it's not a real issue
Comment Actions
It compiles without issue with qalculate 2.0 (in which case CLN_LIBRARIES is not set), so I don't think it's worth complicating the code.
Comment Actions
I tested it with the older libqalculate, and the linking works as well. Let's go for it; is it for Applications/17.08 as you did with other similar commits?