[Folder View] Delay delegate creation until plasmoid expands
ClosedPublic

Authored by broulik on Aug 28 2017, 2:46 PM.

Details

Summary

In Plasma expanded representation is created only on demand but since Folder View is used as containment and already massively complex, all of this is created right away. To speed up startup, delay setting the model until the applet is expanded.

Test Plan

I have 6 FV applets in my panel set to various locations (Pictures, Trash, Home), my Plasma starts half a second faster after this change.

The listingCompleted property could be moved into the FolderModel

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Aug 28 2017, 2:46 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 28 2017, 2:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.Aug 28 2017, 3:34 PM

The listingCompleted property could be moved into the FolderModel

I think it's better to have seperate signals for start and stop here to reinforce the transactional nature ... if this was moved into FM it should be a enum similar to Loader.status imho (which would be nice for sure).

This revision is now accepted and ready to land.Aug 28 2017, 3:34 PM
broulik updated this revision to Diff 18947.Aug 30 2017, 8:10 AM
hein added a comment.Aug 31 2017, 8:47 AM

Looks good, go.

This revision was automatically updated to reflect the committed changes.