Differential D7579

korgac: print the datetime of the reminder consisently with the trigger datetime
ClosedPublic
Actions

Authored by winterz on Aug 27 2017, 10:11 PM.

Details

Reviewers
dvratil
Commits
R210:92a5ef10b6cd: korgac/alarmdialog.cpp: print the reminder datetime consisently with the…
Summary

See bug https://bugs.kde.org/show_bug.cgi?id=382151

display the datetime of reminder in a consistent manner with the trigger datetime

Diff Detail

Repository
R210 KOrganizer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
winterz created this revision.Aug 27 2017, 10:11 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 27 2017, 10:11 PM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
ach added a subscriber: ach.Aug 31 2017, 9:27 AM

Hi Allen, thx! AFAIU it's not commited, so I can't test it via kde neon dev stable or unstable :-( Nevertheless every language that displays the date in non-US format should be fine. So I guess adding Montel, Faure or Dvratil as reviewers should do the trick.

dvratil accepted this revision.Sep 3 2017, 2:18 PM
dvratil added a subscriber: dvratil.

Not tested, but looks good. IncidenceFormatter already used QLocale internally and KLocale::formatDateTime() was used in ShortFormat mode as well.

This revision is now accepted and ready to land.Sep 3 2017, 2:18 PM
Closed by commit R210:92a5ef10b6cd: korgac/alarmdialog.cpp: print the reminder datetime consisently with the… (authored by winterz). · Explain WhySep 3 2017, 3:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkorgac/alarmdialog.cpp (9 lines)

Diff 19142

View Options

korgac/alarmdialog.cpp

Loading...