| mlaurent |
Replace the "Retrieving folder contents" screen with a regular QWidget with a spinner and "Loading message..." message instead (makes more sense than "Retrieving folder contents"). Also replace the "Account/KMail is offline, click here to go online" screens with a regular QWidget with an icon, text and a button to go back online.
| Lint Skipped |
| Unit Tests Skipped |
""Loading message..." message instead (makes more sense than "Retrieving folder contents")" Ok I understand it's a better message for sure.
But what is the improvement to replace it by a qwidget + new dependency to kf5::plasma ?
Now a big button to make online seems really not an improvement.
It's just a framework, we already depend on most of them :D But I can replace it with a QProgressBar if you really don't want the Plasma framework dep - just thought that the Plasma busywidget looks nicer than regular progress bar :)
The idea is to remove the "wallpaper inside application" - with each Plasma release the wallpaper gets outdated anyway and generally is the move in the wrong direction (which VDG also said back when I updated the wallpaper.
So if a problem with wallpaper we can just replace it by a background with gray color for example.
Otherwise we have the same problem with kmail introduction/akregator introduction/kontact introduction we use the same wallpaper.
I prefer it that adding a new QStackedWidget + big pushbutton.
With current version it's correctly integrated with viewer, we have link for switching online or waiting loading message.
The easy method is replacing wallpaper and not recreating a widget for it.