Slave wasn't really deleted (too late for deleteLater when
the KIO Scheduler global object is being deleted).
But actually deleting led to SlaveKeeper using dangling pointers,
so clear it first.
Detected by heaptrack.
mwolff |
Slave wasn't really deleted (too late for deleteLater when
the KIO Scheduler global object is being deleted).
But actually deleting led to SlaveKeeper using dangling pointers,
so clear it first.
Detected by heaptrack.
heaptrack bin/jobtest ; valgrind bin/jobtest (to check no use of deleted memory)
Before: total memory leaked 337 kB After: total memory leaked 232 kB
No Linters Available |
No Unit Test Coverage |
The slaveDied() code path isn't unittested, which is why I didn't detect this earlier.
lgtm, despite the delete this: https://isocpp.org/wiki/faq/freestore-mgmt#delete-this, esp. if you have proper unit tests and ran it through valgrind