Move updateXTime into the X11 standalone platform
ClosedPublic

Authored by graesslin on Aug 24 2017, 3:00 PM.

Details

Summary

KWin::updateXTime only delegates into the platform API where the method
is a no-op. The actual implementation is moved into the X11 standalone
platform as it uses QX11Info which is non functional except on the X11
standalone platform.

This change exposes a problem with timestamp handling: on Wayland the
X11 timestamp does not get updated at all, causing e.g. window sync not
work correctly (c.f. bug 374881). We cannot implement the updating in the
same way as QX11Info/Qt xcb platform does it as that would introduce a
blocking roundtrip to XWayland which is dangerous.

As a side-effect this change removes linking to Qt5::X11Extras in kwin
core as it's no longer needed.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Aug 24 2017, 3:00 PM
Restricted Application added a project: KWin. · View Herald TranscriptAug 24 2017, 3:00 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Aug 24 2017, 4:42 PM
This revision is now accepted and ready to land.Aug 24 2017, 4:42 PM
graesslin updated this revision to Diff 18706.Aug 24 2017, 6:49 PM
  • Disable synced resizing for X11 clients on Xwayland
Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptAug 24 2017, 6:49 PM
graesslin updated this revision to Diff 18707.Aug 24 2017, 6:49 PM

Fix arc mess

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptAug 24 2017, 6:49 PM
This revision was automatically updated to reflect the committed changes.