Differential D7501

Korganizer can use CollectionColorAttributes for calendar colors
ClosedPublic
Actions

Authored by ochurlaud on Aug 24 2017, 6:09 AM.

Details

Reviewers
dvratil
mlaurent
Commits
R210:3c90b8611a74: Korganizer can use CollectionColorAttributes for calendar colors
Summary

KOHelper now calls the EventViews functions of helper.h instead of KOPrefs

KOPrefs is not called anymore by Korganizer for colorResources managing.

This depends on D7500

Diff Detail

Repository
R210 KOrganizer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ochurlaud created this revision.Aug 24 2017, 6:09 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 24 2017, 6:09 AM
dkurz added a subscriber: dkurz.Aug 24 2017, 6:59 AM
dkurz added inline comments.
src/akonadicollectionview.cpp
830

QString identifier in 829 is no longer used

ochurlaud updated this revision to Diff 18705.Aug 24 2017, 6:46 PM

Follow @dkurz corrections

ochurlaud marked an inline comment as done.Aug 24 2017, 6:51 PM
mlaurent requested changes to this revision.Aug 25 2017, 4:37 AM
mlaurent added a subscriber: mlaurent.

Increase eventviews version in toplevel.
Thanks

This revision now requires changes to proceed.Aug 25 2017, 4:37 AM
ochurlaud updated this revision to Diff 18793.Aug 26 2017, 8:25 AM
ochurlaud edited edge metadata.

update eventviews lib version

dvratil accepted this revision.Aug 26 2017, 9:29 AM
Closed by commit R210:3c90b8611a74: Korganizer can use CollectionColorAttributes for calendar colors (authored by ochurlaud). · Explain WhyAug 26 2017, 1:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)
Msrc/akonadicollectionview.cpp (13 lines)
Msrc/kohelper.cpp (30 lines)

Diff 18811

View Options

CMakeLists.txt

Loading...
View Options

src/akonadicollectionview.cpp

Loading...
View Options

src/kohelper.cpp

Loading...