Remove hard X11 runtime dependency from DBusInterface
ClosedPublic

Authored by graesslin on Aug 23 2017, 9:17 AM.

Details

Summary

KWin's DBusInterface announces the service name on an X11 root window
property. For this it requires a runtime dependency on X11. If we would
try to start kwin_wayland without XWayland support this would result in
a crash.

This change turns the dependency into an optional one by checking
whether the KWin::Application has support for X11 and registers a
connection to announce the property as soon as a connection is
established. Thus it even supports the restart of XWayland now.

Test Plan

Compiles

Diff Detail

Repository
R108 KWin
Branch
dbus-interface-no-x11-dependency
Lint
No Linters Available
Unit
No Unit Test Coverage
graesslin created this revision.Aug 23 2017, 9:17 AM
Restricted Application added a project: KWin. · View Herald TranscriptAug 23 2017, 9:17 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Aug 23 2017, 9:46 AM
This revision is now accepted and ready to land.Aug 23 2017, 9:46 AM
This revision was automatically updated to reflect the committed changes.