Differential D7448

generate and use a local cdda_interface headerfile copy
ClosedPublic
Actions

Authored by rjvbb on Aug 21 2017, 8:17 AM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R342:0c31ea5a5373: generate and use a local cdda_interface headerfile copy
Summary

Generates and uses a local copy of the cdda_interface.h header file that
works with C++ instead of using the previous workaround based on
preprocessor macros. That was a hack that breaks the build when
cdda_interface.h includes other header files that use the private
keyword.

Test Plan

works as intended.

Diff Detail

Repository
R342 KIO AudioCD
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rjvbb created this revision.Aug 21 2017, 8:17 AM
rjvbb updated this revision to Diff 18476.Aug 21 2017, 10:29 AM

headerfile processing should be independent of whether it has ioctl_device_name.

rjvbb set the repository for this revision to R342 KIO AudioCD.Aug 21 2017, 10:29 AM
dfaure accepted this revision.Sep 4 2017, 6:50 AM
dfaure added a subscriber: dfaure.

Has this been reported upstream, so the cdda people can fix it properly?

This revision is now accepted and ready to land.Sep 4 2017, 6:50 AM
rjvbb added a comment.Sep 4 2017, 7:56 AM

Not by me in any case, but I didn't exactly "invent" the fix, it must have been around for long enough to be upstreamed. Is cdparanoia even being maintained?

Closed by commit R342:0c31ea5a5373: generate and use a local cdda_interface headerfile copy (authored by rjvbb). · Explain WhyJul 11 2018, 7:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (9 lines)
Maudiocd.cpp (5 lines)
Mplugins/wav/encodercda.cpp (5 lines)

Diff 37541

View Options

CMakeLists.txt

Loading...
View Options

audiocd.cpp

Loading...
View Options

plugins/wav/encodercda.cpp

Loading...