third patch to remove kdelibs4support from frameworks branch
Details
Details
- Reviewers
nhirsl - Group Reviewers
KDE Games - Commits
- R423:ebd26298b400: KF5 port: replace KStandardDirs with QStandardPaths
Images/Puzzles and config is loaded from the correct location (also checked used paths with debugger)
Diff Detail
Diff Detail
- Repository
- R423 Palapeli
- Branch
- review_qstandardpaths
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
I agree with all changes here, except mainwindow.cpp for which I assume was uploaded by mistake.
Comment Actions
I still can see the mainwindow.cpp, it looks like revision wasn't uploaded, not sure? There are just two revisions - latest from this morning - 10:12 AM.
Comment Actions
No, they should be independent from each other. At least they're in separate local branches and compile by their own.
Comment Actions
commited directly with git, not arc...
https://commits.kde.org/palapeli/ebd26298b400be8c085a7c327804c8cce53b8db1