KF5 port: replace KStandardDirs with QStandardPaths
ClosedPublic

Authored by chehrlic on Aug 19 2017, 5:55 PM.

Details

Summary

third patch to remove kdelibs4support from frameworks branch

Test Plan

Images/Puzzles and config is loaded from the correct location (also checked used paths with debugger)

Diff Detail

Repository
R423 Palapeli
Branch
review_qstandardpaths
Lint
No Linters Available
Unit
No Unit Test Coverage
chehrlic created this revision.Aug 19 2017, 5:55 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptAug 19 2017, 5:55 PM
Restricted Application added a subscriber: KDE Games. · View Herald Transcript
nhirsl added a subscriber: nhirsl.Aug 19 2017, 6:05 PM

Does this fix issue (crash) on startup?

src/engine/texturehelper.cpp
73

A bit cleaner solution to this might be QDirIterator
Something like:
QDirIterator it(backgroundsFolder);
while (it.hasNext())

77

I would add here:
if (!pixmap.isNull())
{
...
}

chehrlic updated this revision to Diff 18424.Aug 20 2017, 8:12 AM

update to fix comments from nhirsl

I agree with all changes here, except mainwindow.cpp for which I assume was uploaded by mistake.

Thx for the pointer, I'm still fighting with 'arc'. Now all should be fine.

I still can see the mainwindow.cpp, it looks like revision wasn't uploaded, not sure? There are just two revisions - latest from this morning - 10:12 AM.

chehrlic updated this revision to Diff 18446.Aug 20 2017, 3:05 PM

next try ...

nhirsl accepted this revision.Aug 20 2017, 3:14 PM

Thanks, Christian!

This revision is now accepted and ready to land.Aug 20 2017, 3:14 PM

Does this depend on D7416 and D7417 (the latter has a title too long)?

No, they should be independent from each other. At least they're in separate local branches and compile by their own.