Remove all traces of using Gravatar without transport security

Authored by vkrause on Aug 19 2017, 12:21 PM.



This was effectively disabled in the UI already, but code that doesn't
exist also can't accidentally be reactivated :)

Diff Detail

R88 PIM: Gravatar Library
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Aug 19 2017, 12:21 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 19 2017, 12:21 PM

Turns out this was actually still in use in a kaddressbook plugin in kdepim-addons, so this patch actually found a way to still use this without HTTPS. This would obviously be removed as part of this change going in.

mlaurent requested changes to this revision.Aug 20 2017, 5:28 AM
mlaurent added a subscriber: mlaurent.

Yep it's already use.
So if you want to remove it you need to increase CMake version from libgravatar, create a patch for kdepim-addons and increase version too :)

This revision now requires changes to proceed.Aug 20 2017, 5:28 AM
vkrause updated this revision to Diff 18425.Aug 20 2017, 8:31 AM
vkrause edited edge metadata.

Bumped version number

mlaurent accepted this revision.Aug 20 2017, 11:31 AM
This revision is now accepted and ready to land.Aug 20 2017, 11:31 AM
This revision was automatically updated to reflect the committed changes.