Install browser .desktop file with name used by appstream
Needs ReviewPublic

Authored by jriddell on Aug 18 2017, 2:10 PM.

Details

Reviewers
dfaure
Group Reviewers
Konqueror
Summary

Install browser .desktop file with name used by appstream

Diff Detail

Repository
R226 Konqueror
Branch
arcpatch-D7389_1
Lint
No Linters Available
Unit
No Unit Test Coverage
jriddell created this revision.Aug 18 2017, 2:10 PM
Restricted Application added subscribers: Dolphin, Konqueror. · View Herald TranscriptAug 18 2017, 2:10 PM

Currently appstream file points to a NoDIsplay .desktop files which isn't installed for applications, this means konqueror won't show up in software centres

http://metadata.neon.kde.org/appstream/html/xenial/main/issues/konqueror.html

Isn't the desktop file with NoDisplay a Type=Service? Maybe we just need to rename konqbrowser to the proper name (as requested by the spec anyway).

Yes org.kde.konqueror.desktop is Type=Service installed into ${KDE_INSTALL_KSERVICES5DIR}

So yes renaming konqbrowser.desktop to org.kde.konqueror.desktop seems neater but I'm not sure the best thing to do with the current org.kde.konqueror.desktop then

dfaure edited edge metadata.Aug 23 2017, 9:17 PM

Yes the split makes on sense anymore, kill the NoDisplay stuff, rename konqbrowser to org.kde.konqueror.desktop and install it into the appdir.
Note that it should say X-DBUS-StartupType=unique given that it's a unique app now...

jriddell updated this revision to Diff 18993.Aug 31 2017, 11:26 AM

Updating D7389: Install browser .desktop file with name used by appstream

jriddell updated this revision to Diff 18995.Aug 31 2017, 11:30 AM
  • replace konqbrowser.desktop with org.kde.konqueror.desktop

worked out arc. how's this?

dfaure added inline comments.Sep 3 2017, 7:48 AM
CMakeLists.txt
73

that looks like the wrong destination directory to me. Don't you mean KDE_INSTALL_APPDIR, i.e. moving it up with the PROGRAMS above?

@jriddell ping? what's the status on this one?

meven added a subscriber: meven.Apr 15 2020, 3:31 PM
meven added inline comments.
org.kde.konqueror.desktop
6

Add MimeType=text/html;text/xml;application/xhtml+xml;application/xml;application/rss+xml;application/rdf+xml;image/gif;image/jpeg;image/png;x-scheme-handler/http;x-scheme-handler/https;x-scheme-handler/ftp;inode/directory;