Move X11 movingClient handling into a dedicated X11EventFilter
ClosedPublic

Authored by graesslin on Aug 17 2017, 7:18 PM.

Details

Summary

Splits out the X11 specific window movement handling so that it's not
used in the Wayland case at runtime. As a nice side effect it
un-spaghetties the X11 event handler.

Test Plan

Run nested KWin on Xephyr and nested KWin/Wayland to verify
that move/resize of X11 windows is still working

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Aug 17 2017, 7:18 PM
Restricted Application added a project: KWin. · View Herald TranscriptAug 17 2017, 7:18 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
broulik added inline comments.
moving_client_x11_filter.cpp
37

qobject_cast

graesslin added inline comments.Aug 18 2017, 1:04 PM
moving_client_x11_filter.cpp
37

*shrug* honestly I don't see that the one or the other is better. The old code used dynamic_cast and I try to be as close as possible to the old one.

mart added a subscriber: mart.Aug 18 2017, 1:21 PM
mart added inline comments.
moving_client_x11_filter.cpp
37

both are fine, qobject_cast should be a tad faster, so is probably marginally better to change

This revision was automatically updated to reflect the committed changes.