Properly change buttons hit area to enforce Fitts law when windows are quick-tiled and or vertically/horizontally maximiezed. At the same time, do not draw the window round corners.
ClosedPublic

Authored by hpereiradacosta on Aug 16 2017, 6:45 PM.

Diff Detail

Repository
R31 Breeze
Branch
master-edges
Lint
No Linters Available
Unit
No Unit Test Coverage
Restricted Application added a project: Plasma. · View Herald TranscriptAug 16 2017, 6:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
Zren added a subscriber: Zren.EditedAug 16 2017, 9:49 PM

Neat. I gave it a test.

The right edge now hovers the decoration button, and so does the corner and top edge. However, the top edge and corner still show the "resize" cursors even though you can't resize at that location anymore (it presses the button). Can you confirm that behaviour?

Video: https://streamable.com/iay5r

I first tested the master behaviour, then recompiled with the patch and tested the new behaviour.

ngraham edited edge metadata.Aug 16 2017, 10:21 PM

Yes, Hugo mentioned those current limitations in his comment at https://bugs.kde.org/show_bug.cgi?id=383434. Ideally we would want to resolve those, I think, but this is definitely progress and better than the status quo!

ngraham accepted this revision.Aug 20 2017, 2:51 AM

Now that I think about it, this is fine as-is. You actually can resize a tiled window (unlike a maximized window), so the cursor is giving you accurate information. If you click, the window button will activate, as it visually suggests it will, but if you click and drag, it will resize the window.

This revision is now accepted and ready to land.Aug 20 2017, 2:51 AM
In D7355#136483, @Zren wrote:

Neat. I gave it a test.

The right edge now hovers the decoration button, and so does the corner and top edge. However, the top edge and corner still show the "resize" cursors even though you can't resize at that location anymore (it presses the button). Can you confirm that behaviour?

Video: https://streamable.com/iay5r

I first tested the master behaviour, then recompiled with the patch and tested the new behaviour.

In any case, this cannot be fixed in breeze, as far as I know.
The shape of the cursor is set either in kwin or kdecoration2, not in breeze.
Should file a bug against kwin, if this really is an issue.