Marble Maps design revisions using Kirigami
AcceptedPublic
Actions

Authored by juditbartha on Aug 16 2017, 5:33 PM.

Details

Reviewers

Group Reviewers

Summary

Added support for Kirigami, made changes to CMakeLists. Building Marble Maps now requires Kirigami to be installed in the export folder ( android compiling instructions found here ). Instructions on building Kirigami can be found here.

Todo: Adding instructions on building Kirigami to the compiling notes.

Test Plan

Testing on multiple devices with different resolutions, using emulators to check compatibility with previous Android versions.

Diff Detail

Repository

R34 Marble

Lint

Lint Skipped

Unit

Unit Tests Skipped

juditbartha created this revision.Aug 16 2017, 5:33 PM

juditbartha added a reviewer: Marble: Material Maps.

juditbartha added subscribers: Marble, Marble: Material Maps.

Looks fine.

This revision is now accepted and ready to land.Aug 16 2017, 6:33 PM

Added Kirigami based side panel to Marble Maps.

Thanks. The shortened patches are great for review.

Can you create a new revision for each patch in the future? I nearly missed the update here. That allows to create several ones at once.

Any further updates? :)

rahn added inline comments.Aug 20 2017, 7:24 AM

src/apps/marble-maps/MainScreen.qml
75	I guess in this case just writing accessibilityAction.checked instead of accessibilityAction.checked ? "true" : "false" should be enough ... ;-)

nienhueser added inline comments.Aug 20 2017, 10:28 AM

src/apps/marble-maps/MainScreen.qml
75	I don't think so. The bool -> string conversion is needed.

Revision Contents
Changeset List

			Path	Packages
M			src/apps/marble-maps/CMakeLists.txt (1 line)
M			src/apps/marble-maps/MainScreen.qml (3 lines)
M			src/apps/marble-maps/package/deploy-marble-maps.json.in (1 line)