Differential D7346

Adds contextDrawer to ImageViewer
ClosedPublic
Actions

Authored by atulsharma on Aug 16 2017, 12:34 PM.

Details

Reviewers
mart
Group Reviewers
Koko
Maniphest Tasks
T6268: Implementing the main ImageViewer
Commits
R659:98f1b23c056c: Adds contextDrawer to ImageViewer
Summary

Refs T6268

  • Adds Rotate left and Rotate right actions to the contextDrawer
  • contextDrawer can also be opened by the edit action

Diff Detail

Repository
R659 Koko Image Gallery
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
atulsharma created this revision.Aug 16 2017, 12:34 PM
mart edited edge metadata.Aug 16 2017, 12:36 PM

it should have an handle, the edit action shouldn't be necessary

atulsharma updated this revision to Diff 18231.Aug 16 2017, 12:44 PM

adds handleVisible true

atulsharma updated this revision to Diff 18233.Aug 16 2017, 12:46 PM

removes edit action

mart accepted this revision.Aug 16 2017, 12:48 PM
This revision is now accepted and ready to land.Aug 16 2017, 12:48 PM
Closed by commit R659:98f1b23c056c: Adds contextDrawer to ImageViewer (authored by atulsharma). · Explain WhyAug 16 2017, 12:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MqmlUiKirigami/ImageViewer.qml (30 lines)

Diff 18234

View Options

qmlUiKirigami/ImageViewer.qml

Loading...