Speed up ArtifactEditorModelTest with a shorter autoSaveDelay
ClosedPublic
Actions

Authored by ervin on Aug 16 2017, 8:04 AM.

Details

Reviewers

Commits

Repository

R4 Zanshin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

src/presentation/artifacteditormodel.h
155	No good reason to pollute the header file, a static const int at the top of the cpp file is better, no symbol generated/exported.

Well, can't be const but OK. :-)

Addressing dfaure's comment

Oops yes, I didn't really mean "const" :-)

This revision is now accepted and ready to land.Aug 16 2017, 10:41 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/presentation/artifacteditormodel.h (1 line)
M			src/presentation/artifacteditormodel.cpp (12 lines)
M			tests/units/presentation/artifacteditormodeltest.cpp (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	18219	cd1b125		Aug 16 2017, 8:04 AM	★	★
Diff 2	18259	36257b3	Addressing dfaure's comment	Aug 16 2017, 10:32 PM	★	★
Diff 3	18273	bb84d78	R4:4044038f87562d53e91f30547601f89ea3e975fe	Aug 16 2017, 10:59 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
8af5315e0513	41669ff3fb45	36257b3dde54	Kevin Ottens	Speed up ArtifactEditorModelTest with a shorter autoSaveDelay (Show More…)	Aug 16 2017, 10:31 PM