Don't enter test subdirectories if BUILD_TESTING=OFF
ClosedPublic
Actions

Authored by asturmlechner on Aug 15 2017, 12:37 PM.

Details

Reviewers

Group Reviewers

Commits

Repository

R8 Calligra

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Does this make it possible to remove if(BUILD_TESTING) used in */tests/CMakeLists.txt?
Or is BUILD_TESTING not respected at the moment?

In D7327#135935, @vandenoever wrote:

Does this make it possible to remove if(BUILD_TESTING) used in */tests/CMakeLists.txt?

Yes it would, but I did not find existing use of BUILD_TESTING in the tests subdirs themselves.

Ok, looks like a nice speedup for non-testing builds.

In D7327#135948, @vandenoever wrote:

Ok, looks like a nice speedup for non-testing builds.

Is that a ship-it? ;)

Yes. I was a but reluctant to say ship it because i'm not a core contributor.

This revision is now accepted and ready to land.Aug 21 2017, 7:43 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			filters/stage/powerpoint/CMakeLists.txt (4 lines)
M			libs/flake/CMakeLists.txt (4 lines)
M			libs/odf/CMakeLists.txt (4 lines)
M			libs/pageapp/CMakeLists.txt (4 lines)
M			libs/pigment/CMakeLists.txt (6 lines)
M			libs/rdf/CMakeLists.txt (4 lines)
M			libs/store/CMakeLists.txt (4 lines)
M			libs/text/CMakeLists.txt (6 lines)
M			libs/textlayout/CMakeLists.txt (4 lines)
M			libs/widgets/CMakeLists.txt (4 lines)
M			libs/widgetutils/CMakeLists.txt (4 lines)
M			plan/CMakeLists.txt (4 lines)
M			plan/libs/kernel/CMakeLists.txt (4 lines)
M			plan/libs/models/CMakeLists.txt (4 lines)
M			plan/plugins/schedulers/rcps/CMakeLists.txt (4 lines)
M			plan/plugins/schedulers/tj/CMakeLists.txt (4 lines)
M			plan/plugins/scripting/CMakeLists.txt (4 lines)
M			plugins/chartshape/CMakeLists.txt (4 lines)
M			plugins/colorengines/lcms2/CMakeLists.txt (4 lines)
M			plugins/formulashape/CMakeLists.txt (4 lines)
M			plugins/musicshape/CMakeLists.txt (4 lines)
M			plugins/musicshape/core/CMakeLists.txt (4 lines)
M			plugins/textediting/spellcheck/CMakeLists.txt (4 lines)
M			sheets/CMakeLists.txt (4 lines)
M			stage/part/CMakeLists.txt (2 lines)
M			words/part/CMakeLists.txt (4 lines)