Makes the ImageViewer work with the Type Error issue
AbandonedPublic

Authored by atulsharma on Aug 15 2017, 10:49 AM.

Details

Reviewers
mart
Group Reviewers
Koko
Maniphest Tasks
T6268: Implementing the main ImageViewer
Summary

Refs T6268

  • footer is made visible after the ImageViewer has been poped from the stackview.layer
Test Plan

Testing done

Diff Detail

Repository
R659 Koko Image Gallery
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
atulsharma created this revision.Aug 15 2017, 10:49 AM

Do not show header and footer in full screen mode of imageViewer

mart accepted this revision.Aug 16 2017, 9:49 AM
This revision is now accepted and ready to land.Aug 16 2017, 9:49 AM
mart requested changes to this revision.Aug 16 2017, 9:50 AM
This revision now requires changes to proceed.Aug 16 2017, 9:50 AM
mart added a comment.Aug 16 2017, 9:51 AM

need to wait for my change to be landed

mart added a comment.Aug 16 2017, 9:53 AM

reading it again i think this patch shouldn't go in

qmlUiKirigami/ImageViewer.qml
79

heder and footer needs to never ever be visible when the imageviewer is open, regardless of controlsVisible or not

238

i would prefer controls to be available also on full screen

atulsharma edited edge metadata.

Now it works fine

atulsharma retitled this revision from Removes the visibility on headers and footers of applicationWindow() while opening and closing ImageViewer to Corrects the Type Error issue for mobile UI.Aug 16 2017, 10:49 AM
atulsharma edited the summary of this revision. (Show Details)
atulsharma edited the test plan for this revision. (Show Details)
atulsharma retitled this revision from Corrects the Type Error issue for mobile UI to Makes the ImageViewer work with the Type Error issue.Aug 16 2017, 10:59 AM
atulsharma abandoned this revision.Aug 16 2017, 11:39 AM