Differential D7315

Don't duplicate UI option for automatic speed detection
ClosedPublic
Actions

Authored by davidedmundson on Aug 14 2017, 11:38 PM.

Details

Reviewers
jgrulich
Group Reviewers
Plasma
Commits
R116:e0642ee0d8c0: Don't duplicate UI option for automatic speed detection
Summary

Network speed is determined automatically if "auto-negotiate" is set.
NM Spec says if that is not set a speed and duplex should be provided.

The .ui file (presumably leftover frmo something) defaulted to a speed
of 0 with had the special text of "automatic". This isn't actually
automatic, but just an invalid value which
WiredConnectionWidget::isValid (I think correctly) won't accept

End result is a user can't save any other settings as this widget
reports itself as invalid.

BUG: 383505

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 14 2017, 11:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jgrulich accepted this revision.Oct 3 2017, 11:12 AM
jgrulich added a subscriber: jgrulich.

You are correct, validation expects a value greater than 0 (Automatic). I guess the "Automatic" value was there because various configurations were allowed before, while now it expects speed to be set.

This revision is now accepted and ready to land.Oct 3 2017, 11:12 AM
Closed by commit R116:e0642ee0d8c0: Don't duplicate UI option for automatic speed detection (authored by davidedmundson). · Explain WhyOct 3 2017, 11:15 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 20286

View Options

libs/editor/settings/ui/wiredconnectionwidget.ui

Loading...