SpellCheck: Fix markup rebasing when simple edits are done (one char added)
ClosedPublic

Authored by danders on Aug 14 2017, 10:10 AM.

Details

Summary

Spellcheck called KoTextBlockData::rebaseMarkup() with char position
in *document* instead of position in *block*, which resulted in incorrect markup in
all but the first block.

Adding checks for combined add/remove which cannot be handled by KoTextBlockData::rebaseMarkup().
This means that dropcapped lines will not cause rebase to be done. Instead a full spellcheck
will be triggered for each change. Also markup cannot always keep up with changes to dropcapped lines,
resulting in incorrect/missing markup until next spellcheck is triggered.
Fixes should be done in KoTextLayoutArea, to avoid unneccessary changes to the document.

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
danders created this revision.Aug 14 2017, 10:10 AM
boemann edited edge metadata.Aug 14 2017, 10:39 AM

looks good to me

This revision was automatically updated to reflect the committed changes.