Differential D7290

Always emit Client::captionChanged when the caption changed
ClosedPublic
Actions

Authored by graesslin on Aug 13 2017, 2:56 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Plasma
Commits
R108:f50fbde1a9ed: Always emit Client::captionChanged when the caption changed
Summary

With ddf3536f19a4243670e5fc87f5fbaf9e44031542 a regression got
introduced resulting in Client::captionChanged not being emitted if
Client::setCaption was called without the force parameter.

The regression is only in master branch.

BUG: 383444

Test Plan

Added test case passes

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Aug 13 2017, 2:56 PM
Restricted Application added a project: KWin. · View Herald TranscriptAug 13 2017, 2:56 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Aug 13 2017, 4:20 PM
This revision is now accepted and ready to land.Aug 13 2017, 4:20 PM
Closed by commit R108:f50fbde1a9ed: Always emit Client::captionChanged when the caption changed (authored by graesslin). · Explain WhyAug 13 2017, 5:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 18099

View Options

autotests/integration/x11_client_test.cpp

Loading...
View Options

client.cpp

Loading...