Differential D729

Add Package to activesettings module
ClosedPublic
Actions

Authored by bshah on Jan 1 2016, 1:20 PM.

Details

Reviewers

mart

Group Reviewers

Plasma: Mobile

Commits

R21:9e17097d5f67: Add Package component to activesettings import module

Summary

This unbreaks the plasma-settings, plasma-mobile commit, 962e592afdf2a3f716a36aa370c7fbcaa6 removed MobileComponents.Package. This seems to be only sensible place to add it currently.

Diff Detail

Repository

R21 Plasma Settings

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

bshah updated this revision to Diff 1690.Jan 1 2016, 1:20 PM

bshah retitled this revision from to Add Package to activesettings module.

bshah updated this object.

bshah edited the test plan for this revision. (Show Details)

bshah added reviewers: Plasma: Mobile, mart.

bshah set the repository for this revision to R21 Plasma Settings.

bshah added a project: Plasma: Mobile.

Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptJan 1 2016, 1:20 PM

uploaded correct diff

We'll have to definitely get rid of that class, but for now just to unbreak things is fine

This revision is now accepted and ready to land.Jan 2 2016, 12:32 PM

Closed by commit R21:9e17097d5f67: Add Package component to activesettings import module (authored by bshah). · Explain WhyJan 2 2016, 4:04 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		import/CMakeLists.txt (1 line)
M		import/SettingsItem.qml (2 lines)
A	M	import/package.h (60 lines)
A	M	import/package.cpp (94 lines)
M		import/settingsplugin.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1690			Jan 1 2016, 1:18 PM	★	★
Diff 2	1691			Jan 1 2016, 1:22 PM	★	★
Diff 3	1701	e3f1ca1	Commit rPLASMASETTINGS9e17097d5f6752fc2c4cc4681b32292a3268a8f7	Jan 2 2016, 1:28 PM	★	★