Bug 378032.
With these changes, notifications can be configured to always persist in the notifications applet.
Todo: filter by application, see https://bugs.kde.org/show_bug.cgi?id=378032#c27
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma VDG - Commits
- R120:28d86ab43567: optionally show a history of notifications
Open the notification plasmoid's settings. Check 'Show a history of notifications'. Trigger some notifications. They should show up in the applet.
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Thanks for looking into this.. first round of comments.
| applets/notifications/package/contents/ui/Notifications.qml | ||
|---|---|---|
| 259 | ? | |
| 287 | How does this differ to the persistent delegate? Can we share most of this? | |
| applets/notifications/package/contents/ui/main.qml | ||
| 56–57 | This is now a somewhat confusing name as it's not the total. Then you have the real total under a new name property below. | |
| applets/notifications/package/contents/ui/Notifications.qml | ||
|---|---|---|
| 259 | sorry, missed to revert this... | |
| 287 | It's almost the same. Only the models differ (NotificationsModel is used in NotificationDelegate, NotificationsHistoryModel is used in NotificationHistoryDelegate). I also thought it might be a good idea to use a seperate delegates here, so that in the future history items might have a different visual representation than persistent notifications. If this is not wanted, we could probably make the model a property of NotificationDelegate. | |
Comment Actions
There's a visual quirk I'd like fixing.
Each delegate has a line on the bottom.
However, there's no line between the persistent notifications and the history, so it looks weird.
Maybe a heading "history" would also work.
Also in your last change to my suggestion you've made it so that non persistent items are included in the number in the compact representation.
I don't know if we want that or not.
Comment Actions
- show number of active items in compact representation, excluding history
- show heading above history
- don't show actions in history
| applets/notifications/package/contents/ui/NotificationHistoryDelegate.qml | ||
|---|---|---|
| 27 ↗ | (On Diff #18075) | Why a different delegate for this? all the delegates, persistent or history should be the same |
Comment Actions
@notmart, click the "show older changes" and see reply to my first comment asking the same thing.
| applets/notifications/package/contents/ui/Notifications.qml | ||
|---|---|---|
| 287 | I don't think we would ever want a different visual representation for them, i would consider that a bug, as the thing looks quite busy already. they can be the same file with just a different model property assigned | |
Comment Actions
Cool, do you have commit access?
| applets/notifications/package/contents/ui/Notifications.qml | ||
|---|---|---|
| 92 | *is | |