This simple skips the make step (useful in case make install already
takes care of executing targets part of a simple make invocation)
Details
- Reviewers
sengels vonreth - Commits
- R138:c69497ebb943: Emerge: Add --compile-fast option
Diff Detail
- Lint
No Linters Available - Unit
No Unit Test Coverage
bin/EmergeBase.py | ||
---|---|---|
94 | I would Prefer Compilefast, I once wanted to rename all vars but its so much effort. |
bin/EmergeBase.py | ||
---|---|---|
94 | Can do. Rest okay? Then I'll push |
bin/EmergeBase.py | ||
---|---|---|
94 | Ship it! |
hey, hey, stop, stop. There might be a better solution:
CMake itself has a target nmake install/fast which doesn't retest whether files have been modified and simply runs the install step.
I am against the change in this way, for the following reasons:
- Your option doesn't "compile fast" but simply skips the make step (and redoes it in the install step)
- If you would have that option enabled, running emerge --compile will result in emerge --configure only (which I would call broken)
- If you run emerge --qmerge you would get make, install, and qmerge at the same time.
My proposal would be instead:
- Make emerge --install more flexible: If you run it inside e.g. emerge packagename, it should simply run nmake install/fast instead of nmake install.
- find an option that does the most useful step: run make, and install the executables into the kderoot: as this is the behaviour a normal!!! nmake install would have if you'd run it inside the build directory, we could do this from inside emerge as well.
Based on that last idea, we could also stop using image directories for vanilla cmake packages (those that do not make modifications in their build directory), and thus make the qmerge step for those packages a null operation.
For the record:
I've reverted this change, I've just found EMERGE_NOFAST=False, which has the similar effect, but is implement in a much cleaner way.
Thanks for your remarks.