Differential D7250

Avoid some unnecessary theme content lookups
ClosedPublic
Actions

Authored by fvogt on Aug 11 2017, 12:23 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R242:883a0488f1cb: Avoid some unnecessary theme content lookups
Summary

imagePath can be an absolute path into an iconTheme
-> Do not try to find it in the Plasma theme

imagePath can be empty
-> Do not try to look it up at all

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
fvogt created this revision.Aug 11 2017, 12:23 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 11 2017, 12:23 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
fvogt updated this revision to Diff 18004.Aug 11 2017, 12:24 PM

Forgot a check

mart accepted this revision.Aug 11 2017, 12:31 PM
This revision is now accepted and ready to land.Aug 11 2017, 12:31 PM
fvogt closed this revision.Aug 11 2017, 12:36 PM

Revision Contents
Changeset List

PathPackages
Msrc/plasma/svg.cpp (6 lines)

Diff 18004

View Options

src/plasma/svg.cpp

Loading...