This saves evaluating a new paintedSize and doing a bunch of evaluations
for no reason.
More importantly it works round a Qt animation crash.
CCBUG: 381105
Details
Details
- Reviewers
broulik mart - Group Reviewers
Plasma - Commits
- R120:a44d84ef4749: Don't change fillMode of image just before deleting it
Cloned this code whilst making a tiny reproducible test case
Found swapping these lines made that go away
Given it results in less processing we may as well do it.
End user result is the same.
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
To expand on the crash:
Killer line is
fadeAnim.running = Qt.binding(function() {
return currentImage.status !== Image.Loading && otherImage.status !== Image.Loading })
the idea being to delay the loading until both things are loaded.
But scriptAnimation at the end does:
otherImage.fillMode = fillMode;
otherImage.source = "";
which means from inside the animation we change fillMode - running goes to false as it reloads the image with the new fillMode (asynchronously)
then we unset the source, running goes to true as it's no longer loading
We're completely restarting the animation from within the animation.
Qt doesn't like that.