- make code-block directive looks like a "directive" and not like a "code"
- highlight directive options for code-block (and code) -- just like "other" directives can
- introduce a list of standard directives and their options
- introduce a list of Sphinx directives and their options
- support for "complex" names of roles and directives (like :cmake:command: & etc)
Details
Details
- Reviewers
dhaumann cullmann - Group Reviewers
Kate Framework: Syntax Highlighting
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
In general ok, but there are two issues to be fixed
- Remove spaces around items as noted in the comment
- Please extend / add a highlighting test case in autotest/input/
The goal is to have all highlighting files unit tested, since otherwise we can not maintain this over time.
| data/syntax/rest.xml | ||
|---|---|---|
| 21 ↗ | (On Diff #17991) | Please remove the space before and after attention, i.e. " attention " -> "attention". Syntax highlighting files with spaces raise warnings and soon will not be accepted anymore. The reason for this change was that when loading the xml files, we want to avoid to trim hundreds of thousands of QStrings. Same for all the office items. |
Comment Actions
Looks better, but still, could you provide an autotest case for unit testing, licensed under MIT ?
Comment Actions
Hi, please add a testcase and we are done here.
Without a test case this can easily degenerate later again.
Comment Actions
pong...
I wanted to make some improvements...
And it would be nice to have some hint about how to add the mentioned tests...
Comment Actions
Sorry, for the tests: inside the autotests, there is input/reference/html
Just add your testcase in input, run the tests, take a look at the results and check them in as references.
Comment Actions
@turbov ping again :-) After adding the reference file in autotest/input, run make test, and then call ./autotests/update-reference-data.sh in your build folder. Then git status will tell you which files are new and need to be added updated.
Comment Actions
If you are happy with the current state, I can add some auto-test for you and push this.
Comment Actions
I'm using this syntax 'till nowadays from my repo... I know about some not covered cases in it, but have no time these days to improve it even more %)
Most of the time I quite satisfied w/ it... and sorry for the tests :(
Comment Actions
You can just close this MR, I'll be back sometime later w/ highlighting example and tests...
Comment Actions
Hmm, should we not commit this state at least as is?
Or do you want to do a new request including a new state & tests?
I would be fine with just pushing this as an intermediate step, too.
Comment Actions
Up to you... When I'll fix it for the cases I've found (trying to write the hightlighting.rst test file) I come back w/ a new PR :)
Comment Actions
Ok, then we just close this and wait for the next update.
Thanks for the work on that!