Differential D7238

KMail::KMKernel::collect_collections() invalid QModelIndex
ClosedPublic
Actions

Authored by winterz on Aug 10 2017, 9:47 PM.

Details

Reviewers
mlaurent
Commits
R206:458f59ee0b85: kmkernel.cpp - collect_collections() skip invalid indexes
Summary

In collect_collections() skip over invalid QModelIndex . Helps avoid crash in bug https://bugs.kde.org/show_bug.cgi?id=383362

Diff Detail

Repository
R206 KMail
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
winterz created this revision.Aug 10 2017, 9:47 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 10 2017, 9:47 PM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
mlaurent accepted this revision.Aug 11 2017, 5:04 AM

Yep it seems logical to not adding idx when it's invalid
Thanks

This revision is now accepted and ready to land.Aug 11 2017, 5:04 AM
Closed by commit R206:458f59ee0b85: kmkernel.cpp - collect_collections() skip invalid indexes (authored by winterz). · Explain WhyAug 11 2017, 12:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kmkernel.cpp (6 lines)

Diff 18002

View Options

src/kmkernel.cpp

Loading...