Differential D7226

Fix panning in gmic-qt when using it with a non-RGBA image
ClosedPublic
Actions

Authored by nicholasl on Aug 10 2017, 5:45 AM.

Details

Reviewers
rempt
Group Reviewers
Krita
Commits
R37:30cdbbef34cb: Fix panning in gmic-qt when using it with a non-RGBA image
R37:2781347276cb: Fix panning in gmic-qt when using it with a non-RGBA image
Summary

The position of the source rectangle was not used when converting an image, so attempting to pan in the preview didn't work.
Additionally, this fixes an issue where applying a G'MIC filter to a selection of a non-RGBA layer would not work (this is also present in old plug-in).

This needs D7225 to be applied before its effect can be seen.

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicholasl created this revision.Aug 10 2017, 5:45 AM
rempt accepted this revision.Aug 10 2017, 8:24 AM
This revision is now accepted and ready to land.Aug 10 2017, 8:24 AM
Closed by commit R37:2781347276cb: Fix panning in gmic-qt when using it with a non-RGBA image (authored by nicholasl). · Explain WhyAug 10 2017, 8:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 17958

View Options

plugins/extensions/qmic/kis_qmic_simple_convertor.cpp

Loading...