Differential D7219

Add separate interface library KDev::IExecute for execute/iexecuteplugin.h
ClosedPublic
Actions

Authored by kossebau on Aug 9 2017, 4:32 PM.

Details

Reviewers

kfunk

Group Reviewers

KDevelop

Commits

R32:22db7c2e9d3b: Add separate interface library KDev::IExecute for execute/iexecuteplugin.h

Summary

Avoids adding the ${KDevPlatform_SOURCE_DIR}/plugins dir to the
include dirs of everything linking the "normal" libs

Diff Detail

Repository

R32 KDevelop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau created this revision.Aug 9 2017, 4:32 PM

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptAug 9 2017, 4:32 PM

Rest LGTM,

This is pretty similar to what we did to IMakeBuilder before.

kdevplatform/plugins/execute/CMakeLists.txt
32	KDevPlatformShellExecute -> KDevPlatformExecute?

In D7219#134137, @kfunk wrote:

Rest LGTM,

This is pretty similar to what we did to IMakeBuilder before.

Ah, had not seen, okay, so following a pattern :) Makes me wonder if KDevPlatformExecute then should get some target export, as well right? And perhaps then be named KDevPlatformIExecute (_I_), to indicate the interface as well here?

kdevplatform/plugins/execute/CMakeLists.txt
32	Sure, was a copy, paste & bad-adapt error, should be KDevPlatformExecute, fixed.

In D7219#134140, @kossebau wrote:

In D7219#134137, @kfunk wrote:

Rest LGTM,

This is pretty similar to what we did to IMakeBuilder before.

Ah, had not seen, okay, so following a pattern :) Makes me wonder if KDevPlatformExecute then should get some target export, as well right? And perhaps then be named KDevPlatformIExecute (_I_), to indicate the interface as well here?

+1 on both, yep.

Rename to KDev::IExecute and also export target

kossebau retitled this revision from Add separate interface library KDev::Execute for execute/iexecuteplugin.h to Add separate interface library KDev::IExecute for execute/iexecuteplugin.h.Aug 9 2017, 7:45 PM

kfunk accepted this revision.Aug 9 2017, 8:40 PM

This revision is now accepted and ready to land.Aug 9 2017, 8:40 PM

Closed by commit R32:22db7c2e9d3b: Add separate interface library KDev::IExecute for execute/iexecuteplugin.h (authored by kossebau). · Explain WhyAug 9 2017, 9:22 PM

This revision was automatically updated to reflect the committed changes.

Should we move (some of) this into kdevplatform/interfaces?

Revision Contents
Changeset List

			Path	Packages
M			analyzers/heaptrack/CMakeLists.txt (1 line)
M			debuggers/common/CMakeLists.txt (1 line)
M			debuggers/gdb/CMakeLists.txt (1 line)
M			debuggers/lldb/CMakeLists.txt (1 line)
M			kdeintegration/executeplasmoid/CMakeLists.txt (4 lines)
M			kdevplatform/cmake/modules/KDevPlatformMacrosInternal.cmake (3 lines)
M			kdevplatform/plugins/execute/CMakeLists.txt (11 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	17933	ef9ec8c		Aug 9 2017, 4:32 PM	★	★
Diff 2	17939	ef9ec8c	Rename to KDev::IExecute and also export target	Aug 9 2017, 7:44 PM	★	★
Diff 3	17948	ef9ec8c	R32:22db7c2e9d3bf35ddb122e4089206083faefe4ad	Aug 9 2017, 9:21 PM	★	★