Add separate interface library KDev::IExecute for execute/iexecuteplugin.h
ClosedPublic

Authored by kossebau on Aug 9 2017, 4:32 PM.

Details

Summary

Avoids adding the ${KDevPlatform_SOURCE_DIR}/plugins dir to the
include dirs of everything linking the "normal" libs

Diff Detail

Repository
R32 KDevelop
Branch
makeexecuteiflib
Lint
No Linters Available
Unit
No Unit Test Coverage
kossebau created this revision.Aug 9 2017, 4:32 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptAug 9 2017, 4:32 PM
kfunk added a subscriber: kfunk.Aug 9 2017, 6:24 PM

Rest LGTM,

This is pretty similar to what we did to IMakeBuilder before.

kdevplatform/plugins/execute/CMakeLists.txt
32 ↗(On Diff #17933)

KDevPlatformShellExecute -> KDevPlatformExecute?

In D7219#134137, @kfunk wrote:

Rest LGTM,

This is pretty similar to what we did to IMakeBuilder before.

Ah, had not seen, okay, so following a pattern :) Makes me wonder if KDevPlatformExecute then should get some target export, as well right? And perhaps then be named KDevPlatformIExecute (_I_), to indicate the interface as well here?

kdevplatform/plugins/execute/CMakeLists.txt
32 ↗(On Diff #17933)

Sure, was a copy, paste & bad-adapt error, should be KDevPlatformExecute, fixed.

kfunk added a comment.Aug 9 2017, 7:09 PM
In D7219#134137, @kfunk wrote:

Rest LGTM,

This is pretty similar to what we did to IMakeBuilder before.

Ah, had not seen, okay, so following a pattern :) Makes me wonder if KDevPlatformExecute then should get some target export, as well right? And perhaps then be named KDevPlatformIExecute (_I_), to indicate the interface as well here?

+1 on both, yep.

kossebau updated this revision to Diff 17939.Aug 9 2017, 7:44 PM

Rename to KDev::IExecute and also export target

kossebau retitled this revision from Add separate interface library KDev::Execute for execute/iexecuteplugin.h to Add separate interface library KDev::IExecute for execute/iexecuteplugin.h.Aug 9 2017, 7:45 PM
kfunk accepted this revision.Aug 9 2017, 8:40 PM
This revision is now accepted and ready to land.Aug 9 2017, 8:40 PM
This revision was automatically updated to reflect the committed changes.
apol added a subscriber: apol.Aug 9 2017, 11:07 PM

Should we move (some of) this into kdevplatform/interfaces?