Add virtual Scene::scenePainter method
ClosedPublic

Authored by graesslin on Aug 9 2017, 5:08 AM.

Details

Summary

So far EffectsHandlerImpl directly accessed SceneQPainter::painter
through a dynamic cast. If in future the QPainter based compositor should
be moved into a plugin we cannot access it through a dynamic cast.

To solve this problem the painter method is moved into Scene as
a virtual method returning a sane default value.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Aug 9 2017, 5:08 AM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 9 2017, 5:08 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Aug 9 2017, 10:31 AM
This revision is now accepted and ready to land.Aug 9 2017, 10:31 AM
This revision was automatically updated to reflect the committed changes.