Add virtual Scene::bufferPicture method
ClosedPublic

Authored by graesslin on Aug 8 2017, 5:40 PM.

Details

Summary

So far EffectsHandlerImpl directly accessed SceneXrender::bufferPicture
through a dynamic cast. If in future the XRender based compositor should
be moved into a plugin we cannot access it through a dynamic cast.

To solve this problem the bufferPicture method is moved into Scene as
a virtual method returning a sane default value.

Diff Detail

Repository
R108 KWin
Branch
scene-render-buffer
Lint
No Linters Available
Unit
No Unit Test Coverage
graesslin created this revision.Aug 8 2017, 5:40 PM
Restricted Application added a project: KWin. · View Herald TranscriptAug 8 2017, 5:40 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Aug 8 2017, 6:20 PM
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
scene.h
164

IMHO, as this class is generic, yet the return type is very specific, the name should be reflect that and be
xrenderBufferPicture like effectsHandler has.

This revision is now accepted and ready to land.Aug 8 2017, 6:20 PM
graesslin updated this revision to Diff 17897.Aug 8 2017, 7:06 PM

Incorporated David's naming suggestion

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptAug 8 2017, 7:06 PM
davidedmundson accepted this revision.Aug 8 2017, 7:08 PM
This revision was automatically updated to reflect the committed changes.