This adds Kate sessions as jump list actions that allow to launch Kate with a specific session from application launchers and task manager.
CCBUG: 383249
This adds Kate sessions as jump list actions that allow to launch Kate with a specific session from application launchers and task manager.
CCBUG: 383249
This also conflicts with Kate Sessions runner, so you'll end up with duplicated "Application: Foo - Kate" and "Kate Sessions: Foo" results
Eike came up with a patch for Task Manager to make this work \o/ D7561 and D7562
Lint Skipped |
Unit Tests Skipped |
Looks almost good, I would like to see one more revision with the raised issues :-)
kate/session/katesessionmanager.cpp | ||
---|---|---|
47 | Really needed, see below? | |
95 | Add a comment maybe ? E.g.: | |
521 | Can't we put KDesktopFile on the stack? I don't see a reason for a pointer behind a QScopedPointer, or do I miss something? | |
538 | I don't think this assert() is required, since this is how std::transform() works at its core. | |
547 | Since locateLocal() returns a QString, please turn the const QString& into a simple QString. | |
560 | I would prefert: const int maxEntryCount = std::min(sessionActions.count(), 10); |
kate/session/katesessionmanager.cpp | ||
---|---|---|
521 | KDesktopFile::copyTo returns a new KDesktopFile which I need to dispose of and to avoid having two codepaths for "using the original desktop file" and the "copy" I went this route. If you have any better suggestions, I'm open to it. |
Looks good to me from the Task Manager end. The absolute path thing is true -- I've been pondering that for a while. There's arguments pro and con, this would be another con one.
@broulik If you address the other minor issues, you are good to go, so can you provide an updated patch?
Imho this is somewhat blocked on TM storing absolute paths (or rather it breaking/not updating Kate launchers when I mess with them in the way the patch does). Not sore how to proceed here. @hein Let's discuss this a bit on IRC tomorrow, shall we?
Looks good to me. Thanks for working on this! :)
kate/session/katesessionmanager.cpp | ||
---|---|---|
566 | What is the effect of this TODO? |