Move the X11 specific OverlayWindow into the platform/x11
ClosedPublic
Actions

Authored by graesslin on Aug 7 2017, 4:00 PM.

Details

Reviewers

Group Reviewers

KWin
Plasma

Commits

R108:b4a79d30e64f: Move the X11 specific OverlayWindow into the platform/x11

Summary

The overlay window is only needed for the X11 based compositors. Given
that it is better suited in the X11 platform. Unfortunately it is not
possible to completely move it into the platform plugin as it is still
referenced in KWin core (e.g. SceneXRender). Due to that the
OverlayWindow in KWin core is turned into a pure virtual class with the
implementation being moved into the plugin.

The platform API gains a new virtual factory method which is only
implemented in the X11 platform.

Test Plan

Compiles

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin created this revision.Aug 7 2017, 4:00 PM

Restricted Application added a project: KWin. · View Herald TranscriptAug 7 2017, 4:00 PM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

graesslin added a dependent revision: D7197: Move event filtering for overlay window into an X11EventFilter.Aug 8 2017, 5:13 AM

mart accepted this revision.Aug 10 2017, 3:08 PM

This revision is now accepted and ready to land.Aug 10 2017, 3:08 PM

Closed by commit R108:b4a79d30e64f: Move the X11 specific OverlayWindow into the platform/x11 (authored by graesslin). · Explain WhyAug 12 2017, 9:38 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
P			overlaywindow.h (32 lines) Copied to plugins/platforms/x11/standalone/overlaywindow_x11.h
P			overlaywindow.cpp (151 lines) Copied to plugins/platforms/x11/standalone/overlaywindow_x11.cpp
M			platform.h (7 lines)
M			platform.cpp (6 lines)
M			plugins/platforms/x11/common/eglonxbackend.cpp (2 lines)
M			plugins/platforms/x11/standalone/CMakeLists.txt (1 line)
M			plugins/platforms/x11/standalone/glxbackend.cpp (3 lines)
P			plugins/platforms/x11/standalone/overlaywindow_x11.h (36 lines) Copied from overlaywindow.h
P			plugins/platforms/x11/standalone/overlaywindow_x11.cpp (34 lines) Copied from overlaywindow.cpp
M			plugins/platforms/x11/standalone/x11_platform.h (2 lines)
M			plugins/platforms/x11/standalone/x11_platform.cpp (6 lines)
M			scene_xrender.cpp (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	17842	0028171		Aug 7 2017, 4:00 PM	★	★
Diff 2	18042	bbca8c6	R108:b4a79d30e64f56d9638a465ae199042c82f87ec6	Aug 12 2017, 9:32 AM	★	★

	Status	Author	Revision
	Closed	graesslin	D7197 Move event filtering for overlay window into an X11EventFilter
	Closed	graesslin	D7193 Move the X11 specific OverlayWindow into the platform/x11