Differential D7168

Handle processId being 0 in ShellClient::killWindow
ClosedPublic
Actions

Authored by graesslin on Aug 6 2017, 6:58 PM.

Details

Reviewers
bshah
Group Reviewers
KWin
Plasma
Commits
R108:00281711d9c4: Handle processId being 0 in ShellClient::killWindow
Summary

If ClientConnection fails to get the process id (which happens at least
on FreeBSD) the process id is 0. We should not try to terminate this pid
as it terminates all processes is KWin's process group which is the whole
session.

Test Plan

Only compile test

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Aug 6 2017, 6:58 PM
Restricted Application added a project: KWin. · View Herald TranscriptAug 6 2017, 6:58 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
bshah accepted this revision as: bshah.Aug 7 2017, 5:09 AM
bshah added a subscriber: bshah.

Looks good to me, probably though it's good idea to figure out why it returns 0 as processId?

This revision is now accepted and ready to land.Aug 7 2017, 5:09 AM
Closed by commit R108:00281711d9c4: Handle processId being 0 in ShellClient::killWindow (authored by graesslin). · Explain WhyAug 7 2017, 5:14 AM
This revision was automatically updated to reflect the committed changes.
graesslin added a comment.Aug 7 2017, 5:15 AM
In D7168#133094, @bshah wrote:

Looks good to me, probably though it's good idea to figure out why it returns 0 as processId?

We have a failing auto test for it in KWayland. It looks like libwayland-server is using a linuxism there.

Revision Contents
Changeset List

PathPackages
Mshell_client.cpp (2 lines)

Diff 17798

View Options

shell_client.cpp

Loading...