- do not pop up menu if the only selectable mark (i.e. bookmark) is not the default mark for left click on icon border
Details
Details
- Reviewers
dhaumann - Group Reviewers
KTextEditor - Commits
- R39:7fcdfd95dc69: Ignore default mark in icon border for single selectable mark
Diff Detail
Diff Detail
- Repository
- R39 KTextEditor
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I think the patch makes sense, but I would prefer using a Qt function qPopulationCount to count the bits instead of doing own bitmask magic. Could you provide an updated patch?
src/view/kateviewhelpers.cpp | ||
---|---|---|
2145 | I would prefer using qPopulationCounte (see http://doc.qt.io/qt-5/qtalgorithms.html#qPopulationCount): // is the default or the only editable mark const uint singleMark = (qPopulationCount(editBits) > 1) ? editBits & config->defaultMarkType() : editBits; |