Differential D7162

KSqueezedTextLabel: Add isSqueezed() for convenience
ClosedPublic
Actions

Authored by rkflx on Aug 6 2017, 12:30 PM.

Details

Reviewers
dhaumann
Group Reviewers
Frameworks
Commits
R236:0f440836c548: KSqueezedTextLabel: Add isSqueezed() for convenience
Summary

More readable than having to check fullText!=text() again and again.

Will be used in upcoming autotests, but should be useful in general.

Diff Detail

Repository
R236 KWidgetsAddons
Lint
No Linters Available
Unit
No Unit Test Coverage
rkflx created this revision.Aug 6 2017, 12:30 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 6 2017, 12:30 PM
rkflx edited the summary of this revision. (Show Details)Aug 6 2017, 1:42 PM
dhaumann accepted this revision.Aug 6 2017, 9:20 PM
dhaumann added a subscriber: dhaumann.

A good patch, and adding new non-virtual functions is binary compatible. So this looks good to me.

src/ksqueezedtextlabel.h
110

Suggestion: "and elide mode is set to a value other than Qt::ElideNone" ?

This revision is now accepted and ready to land.Aug 6 2017, 9:20 PM
rkflx updated this revision to Diff 17970.Aug 10 2017, 4:47 PM

Improve wording to be as elegant as suggested by Dominik.

rkflx marked an inline comment as done.Aug 10 2017, 4:49 PM
dhaumann accepted this revision.Aug 22 2017, 8:05 PM

Please commit (also D7161)

Closed by commit R236:0f440836c548: KSqueezedTextLabel: Add isSqueezed() for convenience (authored by rkflx). · Explain WhyAug 24 2017, 7:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/ksqueezedtextlabel.h (9 lines)
Msrc/ksqueezedtextlabel.cpp (9 lines)

Diff 17774

View Options

src/ksqueezedtextlabel.h

Loading...
View Options

src/ksqueezedtextlabel.cpp

Loading...