When saving, kcm_fonts adds the default selected StyleName,
so it needs to specified here as well to avoid mismatches.
BUG: 383191
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma - Commits
- R854:8ed5863a2664: Also specify a default StyleName for fonts
R135:1b21b5977c20: Also specify a default StyleName for fonts
Ran pkcon install with no kdeglobals.
Without this change: Bold title in the auth dialog
With this change: Normal title in the auth dialog
Diff Detail
Diff Detail
- Repository
- R135 Integration for Qt applications in Plasma
- Branch
- stylename
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Note that saving the style name is a bug, see https://bugs.kde.org/show_bug.cgi?id=378523
Comment Actions
While I'm not 100% sure that is true as that's how the user selects the font in kcm_fonts, I still think this patch is
by itself an improvement as the stylenames are provided by the font creators to ship predefined metrics for aesthetics.
Possibly related: https://github.com/qt/qtbase/commit/2bb01172a76f14b1f57010b79207f6b9a9bf3f53
So still ok to land?
Comment Actions
Didn't get closed automatically again...
https://commits.kde.org/plasma-integration/1b21b5977c2068c5bd30c9f9f641f60bdba9ea8e