- sets selection of breakpoint to first position in menu
- show icons for breakpoint and bookmark
before:
after:
Details
Details
Diff Detail
Diff Detail
- Repository
- R33 KDevPlatform
- Branch
- iconborder
- Lint
No Linters Available - Unit
No Unit Test Coverage
| debugger/breakpoint/breakpointmodel.cpp | ||
|---|---|---|
| 168 | That menu is already provided by KTextEditor, right? This adds half-duplicated code from KTextEditor (cf. KateIconBorder::showMarkMenu); I'm not sure this is something we'd like to maintain... I don't fully understand how this adds the icons to the [ ] Breakpoint and [ ] Bookmark actios on the top-level menu though(?), could you elaborate? I'd be happier if we could simplify this patch more. | |
Comment Actions
One solution could be to provide the icons in KateIconBorder::showMarkMenu directly, which I think would be an improvement in any case. What do you think?
| debugger/breakpoint/breakpointmodel.cpp | ||
|---|---|---|
| 168 | Yes, basically it's the same menu in KTextEditor but with icons. The icons are displayed, because since 3b202d26f2ee clicks on no marks are also emitted and BreakpointModel::markContextMenuRequested now only returns unhandled when further mark types are editable. Before, BreakpointModel didn't even notice. | |
Comment Actions
And much simpler, although bookmarks are in first position and there is no separating line... I will abandon this revision as soon as D7458 is accepted.