- sets selection of breakpoint to first position in menu
- show icons for breakpoint and bookmark
That menu is already provided by KTextEditor, right? This adds half-duplicated code from KTextEditor (cf. KateIconBorder::showMarkMenu); I'm not sure this is something we'd like to maintain...
I don't fully understand how this adds the icons to the [ ] Breakpoint and [ ] Bookmark actios on the top-level menu though(?), could you elaborate?
I'd be happier if we could simplify this patch more.
One solution could be to provide the icons in KateIconBorder::showMarkMenu directly, which I think would be an improvement in any case. What do you think?
Yes, basically it's the same menu in KTextEditor but with icons.
The icons are displayed, because since 3b202d26f2ee clicks on no marks are also emitted and BreakpointModel::markContextMenuRequested now only returns unhandled when further mark types are editable. Before, BreakpointModel didn't even notice.