Drop broken mid-button click handling
ClosedPublic

Authored by elvisangelaccio on Aug 5 2017, 3:51 PM.

Details

Summary

It's been broken for years and no one complained, which probably means
no one was using the feature (middle-click to trigger toolbar actions).

While it would be trivial to fix, we probably shouldn't.
It would just make kxmlgui toolbars inconsistent with non-kxmlgui toolbars.

BUG: 383162

Diff Detail

Repository
R263 KXmlGui
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio created this revision.Aug 5 2017, 3:51 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 5 2017, 3:51 PM
dfaure accepted this revision.Aug 9 2017, 7:47 AM
dfaure added a subscriber: dfaure.

Ah, hmm, I used to use that feature. E.g. in konqueror, just like an MMB click would open links in a different tab, MMB on the back button would open the previous page in a different tab.
But OK, that was the time when konqueror features were polluting all of kdelibs, clearly ;)
I can't think of another use case for this.

This revision is now accepted and ready to land.Aug 9 2017, 7:47 AM
This revision was automatically updated to reflect the committed changes.

Dolphin supposedly also made use of this feature at one point: cf. Bug 358649 - given I can middle click almost anything in Dolphin (Places, Folders, Breadcrumbs) I would expect Back/Forward/Up to also open in a new tab.

Dolphin supposedly also made use of this feature at one point: cf. Bug 358649 - given I can middle click almost anything in Dolphin (Places, Folders, Breadcrumbs) I would expect Back/Forward/Up to also open in a new tab.

That could make sense, yes. I added a comment in the bug report.