Don't use find_file for finding files in our own source dir
ClosedPublic

Authored by vkrause on Aug 4 2017, 6:19 PM.

Details

Summary

It's not necessary, and it breaks when cross-compiling, as find_file
changes its behavior then.

Diff Detail

Repository
R311 KWallet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Aug 4 2017, 6:19 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 4 2017, 6:19 PM
kfunk accepted this revision.Aug 7 2017, 8:28 AM
kfunk added a subscriber: kfunk.

I don't see why find_file would be needed here, yep.

This revision is now accepted and ready to land.Aug 7 2017, 8:28 AM
apol added a subscriber: apol.Aug 7 2017, 10:28 AM
apol added inline comments.
src/runtime/kwalletd/CMakeLists.txt
81

How about ${CMAKE_SOURCE_DIR}/src/api/KWallet/org.kde.KWallet.xml?

Making it relative isn't doing much anyway.

vkrause updated this revision to Diff 17843.Aug 7 2017, 4:11 PM

Replace now pointless relative path

kfunk accepted this revision.Aug 7 2017, 6:04 PM
This revision was automatically updated to reflect the committed changes.