Differential D7134

Introduce "Apply to inbound emails in all folders" filter option
ClosedPublic
Actions

Authored by dvratil on Aug 4 2017, 5:41 PM.

Details

Reviewers
mlaurent
aheinecke
Commits
R92:11eef2f6e616: Introduce 'Apply to inbound emails in all folders' filter option

Diff Detail

Repository
R92 PIM: Common Mail Support
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dvratil created this revision.Aug 4 2017, 5:41 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 4 2017, 5:41 PM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
dvratil added a comment.Aug 4 2017, 5:45 PM

Forgot to bump version in CMake, will fix before commit :)

mlaurent added inline comments.Aug 5 2017, 2:54 PM
src/filter/mailfilter.h
205

why adding a default value here ?

dvratil added inline comments.Aug 5 2017, 5:20 PM
src/filter/mailfilter.h
205

The other similar setApply* methods also have a default value, so I used it here too just to keep the API consistent.

mlaurent added inline comments.Aug 7 2017, 4:50 AM
src/filter/mailfilter.h
205

Ah ok API seems wierd.
I will look at if after your commit.

mlaurent accepted this revision.Aug 7 2017, 4:50 AM
This revision is now accepted and ready to land.Aug 7 2017, 4:50 AM
Closed by commit R92:11eef2f6e616: Introduce 'Apply to inbound emails in all folders' filter option (authored by dvratil). · Explain WhyAug 7 2017, 8:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 17808

View Options

CMakeLists.txt

Loading...
View Options

src/filter/filtermanager.h

Loading...
View Options

src/filter/kmfilterdialog.h

Loading...
View Options

src/filter/kmfilterdialog.cpp

Loading...
View Options

src/filter/mailfilter.h

Loading...
View Options

src/filter/mailfilter.cpp

Loading...