QIF importer/exporter had several connections to kmymoney library. Part of them were carried over (e.g. KMyMoneyApp::findAccount), some were removed as they weren't essential (e.g. KExportDlg::slotNewProfile) but are awaiting their return, some were built-in (e.g. KMyMoneyAccountCombo) and some of them were statically linked (e.g. models library) which will require an fix in the future.
Details
Details
- Reviewers
tbaumgart - Group Reviewers
KMyMoney - Commits
- R261:f43ab18a35e4: Move QIF Importer to plugin
Imported test file and exported account with imported contents of test file.
Diff Detail
Diff Detail
- Repository
- R261 KMyMoney
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Did you make sure that the importer can still be used to import statements from institutions as well as import databases from other applications? All in all cool to have this as a plugin.
| kmymoney/plugins/qif/config/mymoneyqifprofileeditordecl.ui | ||
|---|---|---|
| 1 ↗ | (On Diff #17711) | New UI files should not be named with a trailing 'decl'. This stems from KDE3 times, when we needed to subclass a dialog. This is now completely different (we use setupUI) so no need to use these strange naming convention. We have three files xx.ui for those dialogs/widgets etc. |
| kmymoney/plugins/qif/config/qif.json.in | ||
| 19 ↗ | (On Diff #17711) | Make that https |
| kmymoney/plugins/qif/export/qifexport.json.in | ||
| 6 | Won't you add yourself here as well? Also in the other places. | |
| 20 | https | |
| kmymoney/plugins/qif/import/qifimport.json.in | ||
| 20 | https | |
Comment Actions
No. I just moved the code from one place to another and adapted it, so it fits there. QIF processing remains unchanged and if it works in basic case, then it should work in all other cases and if not then someone should correct adaptation of QIF code, so that everything will work just as before pluginizing.
Do you have any suggestion on how I could test it more?
| kmymoney/plugins/qif/config/qif.json.in | ||
|---|---|---|
| 19 ↗ | (On Diff #17711) | This file is here by mistake. |
| kmymoney/plugins/qif/export/qifexport.json.in | ||
| 6 | I guess every little commitment deserves place on credits page. Do you wan't to see here everyone involved? | |