Differential D7098

Remove ClassMemberDeclaration props: isNative/isSynchronized/isStrictFP
ClosedPublic
Actions

Authored by kossebau on Aug 3 2017, 4:04 PM.

Details

Reviewers
egospodinova
ematirov
brauch
kfunk
Group Reviewers
KDevelop
Commits
R33:7bad619faa8f: Remove ClassMemberDeclaration props: isNative/isSynchronized/isStrictFP
R32:7bad619faa8f: Remove ClassMemberDeclaration props: isNative/isSynchronized/isStrictFP
Summary

Also remove left-over bits for final property

All added in 816bf9de8b91314965de27fb5e855eb0d7486871 "to allow java
features to be used (without subclassing of major generic classes)".
But given kdevjava unported to qt5 & unmaintained for years and
nothing else using these properties (by what lxr.kde.org showed),
removing them helps keeping the code clean and as simple as possible.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Aug 3 2017, 4:04 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptAug 3 2017, 4:04 PM
brauch accepted this revision.Aug 3 2017, 4:21 PM
brauch added a subscriber: brauch.

Fine with me. We should really only have things there which are common to at least a few languages, everyone else should declare their own derived data type.

This revision is now accepted and ready to land.Aug 3 2017, 4:21 PM
kfunk accepted this revision.Aug 3 2017, 6:50 PM
Closed by commit R33:7bad619faa8f: Remove ClassMemberDeclaration props: isNative/isSynchronized/isStrictFP (authored by kossebau). · Explain WhyAug 3 2017, 7:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 17662

View Options

language/duchain/classmemberdeclaration.h

Loading...
View Options

language/duchain/classmemberdeclaration.cpp

Loading...
View Options

language/duchain/classmemberdeclarationdata.h

Loading...