check if we're running under X11 before making some X11 calls
remove unused Wacom::X11Info methods
use QScreen in X11Info::getScreenRotation instead of Xrandr
fix X-KDE-Library in wacomtablet.desktop
BUG: 369199
Details
Details
Diff Detail
Diff Detail
- Repository
- R530 Wacom tablet support
- Branch
- releng3.0
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Since those class are called "X11....", can you avoid using those class in the caller instead of make themselves check the platform?
If you don't want to use QX11Info in the caller, you may replace isPlatformX11 by platformName == "xcb" (which is the implementation of isPlatformX11).
src/kded/tabletfinder.cpp | ||
---|---|---|
84 ↗ | (On Diff #21847) | Since we only have one backend here, I would write: if (!QX11Info::isPlatformX11()) { return false; } X11TabletFinder x11tabletFinder; Otherwise if there's any X11 call in X11TabletFinder's constructor, it would still cause problem. Or you can wrap all the code in the if, but I prefer the former one for now since it has less indention. if (QX11Info::isPlatformX11()) { X11TabletFinder x11tabletFinder; ..... } |