Differential D7065

warning--
ClosedPublic
Actions

Authored by sitter on Aug 2 2017, 10:24 AM.

Details

Reviewers
apol
Commits
R120:1bd3145694b6: warning--
Summary

active is unused, don't declare it

Test Plan

no compiler warning raised about the unused var anymore

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Aug 2 2017, 10:24 AM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 2 2017, 10:24 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol accepted this revision.Aug 2 2017, 2:04 PM
This revision is now accepted and ready to land.Aug 2 2017, 2:04 PM
anthonyfieroni added a subscriber: anthonyfieroni.Aug 2 2017, 2:06 PM

So, why don't make lamba without parameters?

sitter added a comment.Aug 2 2017, 2:29 PM
In D7065#131436, @anthonyfieroni wrote:

So, why don't make lamba without parameters?

Same reason it didn't use a (bool activate) signature, whatever that reason might have been I could not say. Not my code.

Closed by commit R120:1bd3145694b6: warning-- (authored by sitter). · Explain WhyAug 2 2017, 2:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 17572

View Options

plasma-windowed/plasmawindowedview.cpp

Loading...